Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Update Workflow's with newer versions of Postgres, Ubuntu, and Checkout action #440

Merged
merged 9 commits into from
Apr 21, 2023

Conversation

mbh329
Copy link
Contributor

@mbh329 mbh329 commented Apr 20, 2023

Addresses issue #439.

Minor PR to address maintenance task to update frequently used tools in our github workflows to the "latest and greatest". Pretty simple stuff, the only thing to note is that I added an option to increase the shared memory capacity to --shm-size=2gb as the PLUTO build is quite large and the default 64gb of shared memory was not sufficient to build PLUTO. The time to build PLUTO was reduced by about 10 minutes with updated versions of PostgreSQL (performance improvements between versions).

Testing the workflows:

I tested a few of the workflows, and the runs are here:

@mbh329 mbh329 added the maintenance Related to regular maintenance label Apr 21, 2023
@mbh329 mbh329 requested review from damonmcc and fvankrieken April 21, 2023 14:26
@fvankrieken
Copy link
Contributor

Test failure is odd - 255 error is an ssh issue. What is ginger exactly?

@fvankrieken
Copy link
Contributor

Actually I don't know if I'm right on that ssh part, need to do a bit more googling on the error

@fvankrieken
Copy link
Contributor

fvankrieken commented Apr 21, 2023

So this bash is a little murky to me. In pluto we have

# resolve path to this file (following symlinks) and load libs
BASEDIR=$( dirname $( ${CMD_READLINK} -f "${BASH_SOURCE[0]}" ) )
for f in ${BASEDIR}/bin/cli.sh ${BASEDIR}/bin/* ; do source $f; done

which is calling this

https://github.com/NYCPlanning/db-pluto/blob/main/pluto_build/bin/cli.sh

@mbh329
Copy link
Contributor Author

mbh329 commented Apr 21, 2023

Ginger is the ftp we get that data from, the process seems to be running totally fine on main. I think the error might be coming from the latest version of ubuntu - let me switch that back to 20.04 and see if it runs

@mbh329
Copy link
Contributor Author

mbh329 commented Apr 21, 2023

@fvankrieken worked when I reverted back to 20.04

@mbh329
Copy link
Contributor Author

mbh329 commented Apr 21, 2023

found this resource related to the issue: actions/runner-images#2791

I am going to see if that fixes the issue with the action

@mbh329
Copy link
Contributor Author

mbh329 commented Apr 21, 2023

the current pts run seems to have gotten past the earlier issue, it is no no longer throwing the mysterious 255 Error Code

@fvankrieken
Copy link
Contributor

Very strange. If things are running fine now, I would say good to merge=

@mbh329
Copy link
Contributor Author

mbh329 commented Apr 21, 2023

I messed up and ran the PTS workflow with the 20.04 version of ubuntu and it worked so I actually can't get the workflow to work with a newer version of ubuntu, I think it makes sense to just leave it at 20.04 and monitor these workflows when we rebuild PLUTO. Does that sound good to yall?

@mbh329 mbh329 merged commit 63e5934 into main Apr 21, 2023
@fvankrieken fvankrieken deleted the mbh-439-update-workflow-extensions branch June 5, 2023 18:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Related to regular maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants